Skip to content

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Sep 25, 2025

Does not affect published files.

I think these were added accidentally in #33441 due to copy&paste. react-dom/static.edge doesn't have these methods either.

Noticed this while diffing against latest stable release. The published entrypoints didn't have them. Just the entrypoints for tests.

@meta-cla meta-cla bot added the CLA Signed label Sep 25, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Sep 25, 2025
@react-sizebot
Copy link

Comparing: c44fbf4...8f468de

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 534.43 kB 534.43 kB = 94.33 kB 94.33 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.69 kB 663.69 kB = 117.00 kB 117.00 kB
facebook-www/ReactDOM-prod.classic.js = 687.59 kB 687.59 kB = 121.04 kB 121.04 kB
facebook-www/ReactDOM-prod.modern.js = 678.02 kB 678.02 kB = 119.40 kB 119.40 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 8f468de

@eps1lon eps1lon changed the title [Fizz] Remove renderToString and renderToStaticMarkup from react-dom/static [Fizz] Match test entrypoints and published entrypoints. Sep 25, 2025
@eps1lon eps1lon changed the title [Fizz] Match test entrypoints and published entrypoints. Match react-dom/static test entrypoints and published entrypoints. Sep 25, 2025
@eps1lon eps1lon changed the title Match react-dom/static test entrypoints and published entrypoints. Match react-dom/static test entrypoints and published entrypoints Sep 25, 2025
@eps1lon eps1lon requested a review from sebmarkbage September 25, 2025 11:38
@eps1lon eps1lon marked this pull request as ready for review September 25, 2025 11:38
@eps1lon eps1lon merged commit e08f53b into facebook:main Sep 28, 2025
250 checks passed
@eps1lon eps1lon deleted the sebbie/09-25-_fizz_remove_rendertostring_and_rendertostaticmarkup_from_react-dom/static_ branch September 28, 2025 11:26
EugeneChoi4 pushed a commit to EugeneChoi4/react that referenced this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants