[Perf Tracks]: Always log effect that spawned blocking update #34648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: ef88944...908c588 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
reviewed
Sep 30, 2025
| if (!enableProfilerTimer || !enableProfilerCommitHooks) { | ||
| return 0; | ||
| } | ||
| componentEffectSpawnedUpdate = false; // Reset. |
There was a problem hiding this comment.
There's no equivalent pop here. That means that this is not scoped to a single component and will leak to siblings. I believe it may also get reset in the case that an effect is in the beginning of the recursion.
I think another issue is that this probably makes this outlined instead of inlined.
The correct way would be to make another pushComponentEffectX with a paired popComponentEffectX. Just like pushComponentEffectDuration etc. do. So that the previous value can be stored and popped at the end.
There was a problem hiding this comment.
Makes sense, thanks for the context. Updated.
hoxyq
force-pushed
the
refactor/always-log-effect-that-spawned-update
branch
from
970d9cc to
908c588
Compare
sebmarkbage
approved these changes
Sep 30, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2025
We've observed some scenarios, where cascading update happens in an effect that was shorter than 0.05ms. In this case, this effect won't be displayed on a timeline, because of the threshold that we are using, but it would be shown in entry properties or in a stack trace. To avoid confusion, we should always log such effects. Validated via manually changing the threshold to 100ms+ and observing that only effects that triggered an update are visible on a timeline. DiffTrain build for [063394c](063394c)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2025
We've observed some scenarios, where cascading update happens in an effect that was shorter than 0.05ms. In this case, this effect won't be displayed on a timeline, because of the threshold that we are using, but it would be shown in entry properties or in a stack trace. To avoid confusion, we should always log such effects. Validated via manually changing the threshold to 100ms+ and observing that only effects that triggered an update are visible on a timeline. DiffTrain build for [063394c](063394c)
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed some scenarios, where cascading update happens in an effect that was shorter than 0.05ms. In this case, this effect won't be displayed on a timeline, because of the threshold that we are using, but it would be shown in entry properties or in a stack trace.
To avoid confusion, we should always log such effects.
Validated via manually changing the threshold to 100ms+ and observing that only effects that triggered an update are visible on a timeline.