Skip to content

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Sep 29, 2025

We selected the root. This means that we're currently viewing the Transition that rendered the whole screen. In laymans terms this is really "Initial Paint". Once we add subtree selection, then the equivalent should be called "Transition" since in that case it's really about a Transition within the page. So if you've selected an Activity tree this should be called "Transition".

Once we add the environment support to the timeline. The first entry on the timeline should also be called "Initial Paint" when you haven't selected an Activity and "Transition" when you have.

Technically they're both meant to be "Transition" but nobody thinks of initial load as a "Transition" from the previous MPA page.

Screenshot 2025-09-29 at 5 18 58 PM

@sebmarkbage sebmarkbage requested a review from eps1lon September 29, 2025 20:34
@meta-cla meta-cla bot added the CLA Signed label Sep 29, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Sep 29, 2025
@sebmarkbage
Copy link
Collaborator Author

I guess I could make this clickable just like the other one. It's kind of weird, since it should always be selected already. It's not quite true today due to the annoying case where you can jump to a non-Suspense.

@sebmarkbage sebmarkbage merged commit 0d8ff4d into facebook:main Sep 30, 2025
241 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants