Fix "Consecutive" Event Logs in Performance Track #34659
Merged
+29
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to track repeat updates separately.
github-actions
bot
added
the
React Core Team
|
Comparing: a55e98f...a7f364d Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
hoxyq
reviewed
Sep 30, 2025
hoxyq
approved these changes
Sep 30, 2025
Co-authored-by: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com>
rickhanlonii
approved these changes
Oct 1, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
Reset EventTime when clearing timers. We need to track repeat updates separately. Typically we always reset all timers when we've logged an update. The same update shouldn't be logged again. I was trying to be clever and not reset the XEventTime because we also need the timestamp to know if it's a repeat event. However, because of this it looked like we had an event schedule an update even after we had reset them. This always resets the XEventTime to -1.1 and then stashes the old time on EventRepeatTime which is our indication whether the next update was a repeat of the old event. --------- Co-authored-by: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com> Co-authored-by: Ricky <rickhanlonii@gmail.com> DiffTrain build for [7bccdbd](7bccdbd)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
Reset EventTime when clearing timers. We need to track repeat updates separately. Typically we always reset all timers when we've logged an update. The same update shouldn't be logged again. I was trying to be clever and not reset the XEventTime because we also need the timestamp to know if it's a repeat event. However, because of this it looked like we had an event schedule an update even after we had reset them. This always resets the XEventTime to -1.1 and then stashes the old time on EventRepeatTime which is our indication whether the next update was a repeat of the old event. --------- Co-authored-by: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com> Co-authored-by: Ricky <rickhanlonii@gmail.com> DiffTrain build for [7bccdbd](7bccdbd)
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset EventTime when clearing timers. We need to track repeat updates separately.
Typically we always reset all timers when we've logged an update. The same update shouldn't be logged again.
I was trying to be clever and not reset the XEventTime because we also need the timestamp to know if it's a repeat event. However, because of this it looked like we had an event schedule an update even after we had reset them.
This always resets the XEventTime to -1.1 and then stashes the old time on EventRepeatTime which is our indication whether the next update was a repeat of the old event.