Skip to content

[lint] Remove experimental gating useEffectEvent rules #34660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

[lint] Remove experimental gating useEffectEvent rules #34660

merged 1 commit into from
Sep 30, 2025
+161 −185

Conversation

jackpope
Copy link
Contributor

Stacked on #34637

useEffectEvent is now in canary so we need to remove this __EXPERIMENTAL__ gating on the rules and tests

@meta-cla meta-cla bot added the CLA Signed label Sep 30, 2025
@jackpope jackpope requested a review from jbrown215 September 30, 2025 20:37
@jackpope jackpope mentioned this pull request Sep 30, 2025
Merged
@react-sizebot
Copy link

react-sizebot commented Sep 30, 2025 •
edited
Loading

Comparing: 2a04bae...0d0e0c6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 536.16 kB 536.16 kB = 94.80 kB 94.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.75 kB 663.75 kB = 117.02 kB 117.02 kB
facebook-www/ReactDOM-prod.classic.js = 687.70 kB 687.70 kB = 121.07 kB 121.07 kB
facebook-www/ReactDOM-prod.modern.js = 678.12 kB 678.12 kB = 119.43 kB 119.43 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0d0e0c6

@jackpope jackpope force-pushed the ship-useeffectevent-rules branch from a3167e5 to 0d0e0c6 Compare September 30, 2025 20:51
@jackpope jackpope merged commit 57b16e3 into facebook:main Sep 30, 2025
240 of 241 checks passed
@jackpope jackpope deleted the ship-useeffectevent-rules branch September 30, 2025 20:55
github-actions bot pushed a commit that referenced this pull request Sep 30, 2025
@jackpope
[lint] Remove experimental gating useEffectEvent rules (#34660)
e064d0a 
Stacked on #34637

`useEffectEvent` is now in canary so we need to remove this
`__EXPERIMENTAL__` gating on the rules and tests

DiffTrain build for [57b16e3](57b16e3)
github-actions bot pushed a commit that referenced this pull request Sep 30, 2025
@jackpope
[lint] Remove experimental gating useEffectEvent rules (#34660)
ade416d 
Stacked on #34637

`useEffectEvent` is now in canary so we need to remove this
`__EXPERIMENTAL__` gating on the rules and tests

DiffTrain build for [57b16e3](57b16e3)
This was referenced Oct 1, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrown215 jbrown215 jbrown215 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackpope @react-sizebot @jbrown215