[DevTools] Fix host instance highlighting #34661
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Sep 30, 2025
| if (nodes != null) { | ||
| for (let i = 0; i < nodes.length; i++) { | ||
| const node = nodes[0]; | ||
| const node = nodes[i]; |
There was a problem hiding this comment.
This fixes e.g. the Initial Paint not getting any highlights.
There was a problem hiding this comment.
Well I was planning on actually disabling it for the whole document since it's really annoying to flash the whole document every time you hover over a background or first step.
eps1lon
commented
Sep 30, 2025
| className={styles.SuspenseBreadcrumbsListItem} | ||
| aria-current={selectedSuspenseID === id} | ||
| onPointerEnter={highlightHostInstance.bind(null, id)} | ||
| onPointerEnter={highlightHostInstance.bind(null, id, false)} |
There was a problem hiding this comment.
This fixes a crash. Flow.js doesn't have typings for Host Components so this slipped through.
sebmarkbage
approved these changes
Oct 1, 2025
eps1lon
deleted the
sebbie/09-30-_devtools_fix_host_instance_highlighting
branch
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.