Skip to content

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Oct 1, 2025

prerender doesn't accept a nonce because the nonce wouldn't be unique to the request. The same applies to resumeAndPrerender.

@eps1lon eps1lon requested review from sebmarkbage and gnoff October 1, 2025 09:44
@meta-cla meta-cla bot added the CLA Signed label Oct 1, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Oct 1, 2025
@react-sizebot
Copy link

Comparing: cf88408...8bf099c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 536.16 kB 536.16 kB = 94.80 kB 94.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.75 kB 663.75 kB = 117.02 kB 117.02 kB
facebook-www/ReactDOM-prod.classic.js = 687.70 kB 687.70 kB = 121.07 kB 121.07 kB
facebook-www/ReactDOM-prod.modern.js = 678.12 kB 678.12 kB = 119.43 kB 119.43 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +1,089.17% 178.16 kB 2,118.66 kB +903.50% 30.32 kB 304.29 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +1,089.06% 178.16 kB 2,118.47 kB +903.43% 30.32 kB 304.27 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +1,089.06% 178.16 kB 2,118.47 kB +903.43% 30.32 kB 304.27 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +1,086.30% 178.22 kB 2,114.19 kB +902.03% 30.27 kB 303.28 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +1,086.19% 178.22 kB 2,114.00 kB +901.96% 30.27 kB 303.26 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +1,086.19% 178.22 kB 2,114.00 kB +901.96% 30.27 kB 303.26 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +1,089.17% 178.16 kB 2,118.66 kB +903.50% 30.32 kB 304.29 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +1,089.06% 178.16 kB 2,118.47 kB +903.43% 30.32 kB 304.27 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +1,089.06% 178.16 kB 2,118.47 kB +903.43% 30.32 kB 304.27 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +1,086.30% 178.22 kB 2,114.19 kB +902.03% 30.27 kB 303.28 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +1,086.19% 178.22 kB 2,114.00 kB +901.96% 30.27 kB 303.26 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +1,086.19% 178.22 kB 2,114.00 kB +901.96% 30.27 kB 303.26 kB

Generated by 🚫 dangerJS against 8bf099c

@eps1lon eps1lon merged commit 2f0649a into facebook:main Oct 1, 2025
247 checks passed
@eps1lon eps1lon deleted the sebbie/10-01-_fizz_remove_nonce_option_from_resume-and-prerender_apis branch October 1, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants