-
Notifications
You must be signed in to change notification settings - Fork 49.5k
Enable React performance tracks in Canary #34665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable React performance tracks in Canary #34665
Conversation
e4ee5df
to
c810e5b
Compare
export const enableHydrationChangeEvent: boolean = true; | ||
export const enableDefaultTransitionIndicator: boolean = true; | ||
export const ownerStackLimit = 1e4; | ||
export const enableComponentPerformanceTrack: boolean = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this for now
|
||
export const enableFastAddPropertiesInDiffing: boolean = __VARIANT__; | ||
export const enableViewTransition: boolean = __VARIANT__; | ||
export const enableComponentPerformanceTrack: boolean = __VARIANT__; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this
c810e5b
to
f39856a
Compare
@eps1lon Can you also enable it in Otherwise it won't be enabled in next React Native release that will use react@19.2.0. |
Also, this might need an update for backwards compatibility:
|
Co-authored-by: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com>
f39856a
to
8ba7e8e
Compare
8ba7e8e
to
84c8523
Compare
All usages are already gated on enableProfilerTimer i.e. PROFILE. We want to clean it up eventually so it's better to use
true
to make it obvious it can be removed.Meta builds are still dynamic.