-
Notifications
You must be signed in to change notification settings - Fork 49.5k
Release <ViewTransition />
to Canary
#34712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Release <ViewTransition />
to Canary
#34712
Conversation
69f1b2a
to
cb62af3
Compare
cb62af3
to
79e63b5
Compare
ViewTransition
and addTransitionType
in CanaryViewTransition
and addTransitionType
to Canary
ViewTransition
and addTransitionType
to Canary<ViewTransition />
to Canary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment, and we need to merge the docs at the same time.
packages/react/src/ReactServer.fb.js
Outdated
* @flow | ||
*/ | ||
|
||
import {enableViewTransition} from 'shared/ReactFeatureFlags'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be safe, can you remove the feature flag and just continue exporting it as unstable_ViewTransition
? I have no idea if turning this off would break our infra.
I need to cut a Canary first so this needs to go in first before docs go out. |
f22aea7
to
bac4b8d
Compare
Overview
This PR ships the View Transition APIs to
react@canary
:<ViewTransition />
addTransitionType
This means these APIs are ready for final feedback and prepare for semver stable release.
What this means
Shipping
<ViewTransition />
andaddTransitionType
to canary means they have gone through extensive testing in production, we are confident in the stability of the APIs, and we are preparing to release it in a future semver stable version.Libraries and frameworks following the Canary Workflow should begin implementing and testing these features.
Why we follow the Canary Workflow
To prepare for semver stable, libraries should test canary features like
<ViewTransition />
withreact@canary
to confirm compatibility and prepare for the next semver release in a myriad of environments and configurations used throughout the React ecosystem. This provides libraries with ample time to catch any issues we missed before slamming them with problems in the wider semver release.Since these features have already gone through extensive production testing, and we are confident they are stable, frameworks following the Canary Workflow can also begin adopting canary features like
<ViewTransition />
.This adoption is similar to how different Browsers implement new proposed browser features before they are added to the standard. If a frameworks adopts a canary feature, they are committing to stability for their users by ensuring any API changes before a semver stable release are opaque and non-breaking to their users.
Apps not using a framework are also free to adopt canary features like
<ViewTransition>
as long as they follow the Canary Workflow, but we generally recommend waiting for a semver stable release unless you have the capacity to commit to following along with the canary changes and debugging library compatibility issues.Waiting for semver stable means you're able to benefit from libraries testing and confirming support, and use semver as signal for which version of a library you can use with support of the feature.
Docs
Check out the "React Labs: View Transitions, Activity, and more" blog post, and the new docs for
<ViewTransition />
andaddTransitionType
for more info.