-
Notifications
You must be signed in to change notification settings - Fork 49.5k
Release Fragment refs to Canary #34720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eps1lon
wants to merge
2
commits into
facebook:main
Choose a base branch
from
eps1lon:sebbie/10-03-release_fragment_refs_to_canary
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release Fragment refs to Canary #34720
eps1lon
wants to merge
2
commits into
facebook:main
from
eps1lon:sebbie/10-03-release_fragment_refs_to_canary
+22
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing: d6eb735...ab0cf48 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the
ref
prop to<Fragment>
inreact@canary
.This means this API is ready for final feedback and prepared for a semver stable release.
What this means
Shipping Fragment refs to canary means they have gone through extensive testing in production, we are confident in the stability of the APIs, and we are preparing to release it in a future semver stable version.
Libraries and frameworks following the Canary Workflow should begin implementing and testing these features.
Why we follow the Canary Workflow
To prepare for semver stable, libraries should test canary features like Fragment refs with
react@canary
to confirm compatibility and prepare for the next semver release in a myriad of environments and configurations used throughout the React ecosystem. This provides libraries with ample time to catch any issues we missed before slamming them with problems in the wider semver release.Since these features have already gone through extensive production testing, and we are confident they are stable, frameworks following the Canary Workflow can also begin adopting canary features like Fragment refs.
This adoption is similar to how different Browsers implement new proposed browser features before they are added to the standard. If a frameworks adopts a canary feature, they are committing to stability for their users by ensuring any API changes before a semver stable release are opaque and non-breaking to their users.
Apps not using a framework are also free to adopt canary features like Fragment refs as long as they follow the Canary Workflow, but we generally recommend waiting for a semver stable release unless you have the capacity to commit to following along with the canary changes and debugging library compatibility issues.
Waiting for semver stable means you're able to benefit from libraries testing and confirming support, and use semver as signal for which version of a library you can use with support of the feature.
Docs
Check out the "React Labs: View Transitions, Activity, and more" blog post, and the new docs for Fragment refs` for more info.