[Perf Tracks]: Clear potentially large measures #34803
Open
+15
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxyq
commented
Oct 10, 2025
| }; | ||
|
|
||
| const resuableChangedPropsEntry = ['Changed Props', '']; | ||
| const reusableChangedPropsEntry = ['Changed Props', '']; |
|
Comparing: 8454a32...0d9a0b5 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34770.
We need to clear measures at some point, otherwise all these copies of props that we end up recording will allocate too much memory in Chromium. This adds
performance.clearMeasures(...)calls to such cases in DEV.We can also consider clearing all measures. The only drawback I can think of right now is that they won't be available in
performance.getEntries()andPerformanceObserver, but that doesn't really make any sense for DEV envs.Validated that entries are still shown on Performance panel timeline.