Track fiber tests #7812
Merged
Track fiber tests #7812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the newly added tracking system to track the number of fiber tests that are passing/failing. I first tried to modify the grunt lint rule for it and send the output in stdout but unfortunately grunt displays the rule + done messages there. I had like 30 lines of js already and I figured I could just write 3 lines of bash and it would work the same. Let me know if you want me to use another approach for it. Test Plan: Run the commands that have been introduced in this commit but the facts-tracker one Run `echo $FIBER_TESTS` and make sure it prints `666/1434`
ghost
added
zpao
approved these changes
Sep 26, 2016
zpao
pushed a commit
that referenced
this pull request
Oct 4, 2016
Use the newly added tracking system to track the number of fiber tests that are passing/failing. I first tried to modify the grunt lint rule for it and send the output in stdout but unfortunately grunt displays the rule + done messages there. I had like 30 lines of js already and I figured I could just write 3 lines of bash and it would work the same. Let me know if you want me to use another approach for it. Test Plan: Run the commands that have been introduced in this commit but the facts-tracker one Run `echo $FIBER_TESTS` and make sure it prints `666/1434` (cherry picked from commit 84f8df1)
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
Use the newly added tracking system to track the number of fiber tests that are passing/failing. I first tried to modify the grunt lint rule for it and send the output in stdout but unfortunately grunt displays the rule + done messages there. I had like 30 lines of js already and I figured I could just write 3 lines of bash and it would work the same. Let me know if you want me to use another approach for it. Test Plan: Run the commands that have been introduced in this commit but the facts-tracker one Run `echo $FIBER_TESTS` and make sure it prints `666/1434`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the newly added tracking system to track the number of fiber tests that are passing/failing.
I first tried to modify the grunt lint rule for it and send the output in stdout but unfortunately grunt displays the rule + done messages there. I had like 30 lines of js already and I figured I could just write 3 lines of bash and it would work the same. Let me know if you want me to use another approach for it.
Test Plan:
Run the commands that have been introduced in this commit but the facts-tracker one
Run
echo $FIBER_TESTSand make sure it prints666/1434