Fix npm package builds #7888
Merged
Fix npm package builds #7888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were running this on the original packages not the compiled ones, resulting in missing files
|
lgtm |
zpao
added a commit
that referenced
this pull request
Oct 5, 2016
* Ensure lib/ is packaged for react-test-renderer * Run npm pack from right working directory We were running this on the original packages not the compiled ones, resulting in missing files (cherry picked from commit 077d660)
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
* Ensure lib/ is packaged for react-test-renderer * Run npm pack from right working directory We were running this on the original packages not the compiled ones, resulting in missing files
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* Ensure lib/ is packaged for react-test-renderer * Run npm pack from right working directory We were running this on the original packages not the compiled ones, resulting in missing files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes both parts of #7880 and then the same for
react-native-renderer.lib/inreact-test-renderernpm packon the compiled packages, not the original src.cc @aweary @spicyj