Hack to fix lint with yarn #7997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related Yarn issue yarnpkg/yarn#1158 |
sebmarkbage
commented
Oct 18, 2016
| version "6.11.5" | ||
| resolved "https://registry.npmjs.org/babylon/-/babylon-6.11.5.tgz#35cce8fb5f98353931d275cb56871fbf17bf9a00" | ||
| babylon@6.8.0: | ||
| babylon@^6.0.18, babylon@^6.11.0, babylon@^6.8.1, babylon@6.8.0: |
There was a problem hiding this comment.
This is the hack. The rest are just regular updates.
I couldn't figure out how to do this yarn alone so I ended up just manually hacking the yarn to force a downgrade of babylon to 6.8.0 since otherwise it gets resolved to 6.12.0 which is broken.
|
@sebmarkbage What's the issue with babylonv6.12.0? Feel free to ping me on related Babel issues or file an issue in babylon |
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
I couldn't figure out how to do this yarn alone so I ended up just manually hacking the yarn to force a downgrade of babylon to 6.8.0 since otherwise it gets resolved to 6.12.0 which is broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Babylon 6.12.0 is broken. (Maybe related to babel/babel-eslint#280 )
I couldn't figure out how to do this using package configuration alone so I ended up just manually hacking the yarn.lock file to force a downgrade of babylon to 6.8.0 since otherwise it gets resolved to 6.12.0 which is broken.