Get a few more Fiber tests passing #8149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
approved these changes
Oct 29, 2016
src/shared/utils/getComponentName.js
Outdated
|
|
||
| 'use strict'; | ||
|
|
||
| function getComponentName(internalInstance) : string | null { |
There was a problem hiding this comment.
Can we make this DEV only so that we are guaranteed to only use it in DEV?
|
Looks like you have a Flow issue but otherwise lgtm. |
|
Is this okay? If I wrap whole module in |
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
* Get a few more Fiber tests passing * Fix Flow and wrap in __DEV__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a small indirection so that isomorphic and shared DOM modules don't depend on
getName()method being present on the owner (which can now be a fiber).