Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Only attempt to clear measures if we created the measure #9451
This fixes an issue where if we decided not to create a measurement we would clear ALL measurements from the performance entry buffer due to passing
The original bug here means any
For reference see the performance.clearMeasures spec.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at email@example.com. Thanks!
If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact firstname.lastname@example.org if you have any questions.
This seems fine as is, thanks! We don’t need a test because this code will be deleted in the next release (the perf integration is in a different place in Fiber). I think the new code doesn’t have this issue, but you can check
I’ll make a note to cherry-pick this commit in 15.6.