New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-transition-group from npm #9937

Merged
merged 1 commit into from Jun 12, 2017

Conversation

Projects
None yet
4 participants
@gaearon
Member

gaearon commented Jun 12, 2017

Note: I have not tested this yet.

This should point react-addons-transition-group to API-compatible versions of react-transition-group package. This lets it keep working in observable future. So we don't need to deprecate it officially (even though we will keep the npm package deprecated and suggest people to migrate to new package explicitly).

cc @jquense

@gaearon gaearon requested a review from flarnie Jun 12, 2017

@flarnie

This comment has been minimized.

Show comment
Hide comment
@flarnie

flarnie Jun 12, 2017

Contributor

If/when I have time I can come back to this and manually test it. I think we could use the 'browserify' fixture and require and use it there to manually test.

Contributor

flarnie commented Jun 12, 2017

If/when I have time I can come back to this and manually test it. I think we could use the 'browserify' fixture and require and use it there to manually test.

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jun 12, 2017

Member

I'm going to assume it works—I'll do another round of testing anyway as I complete preparing this, and I'd rather test them all at once.

Member

gaearon commented Jun 12, 2017

I'm going to assume it works—I'll do another round of testing anyway as I complete preparing this, and I'd rather test them all at once.

@gaearon gaearon merged commit dea8f6a into facebook:15.6-dev Jun 12, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@gaearon gaearon deleted the gaearon:use-transition-group branch Jun 12, 2017

@jquense

This comment has been minimized.

Show comment
Hide comment
@jquense

jquense Jun 13, 2017

Collaborator

Looks like it should work to me...i don't think I changed the exports at all 👍

Collaborator

jquense commented Jun 13, 2017

Looks like it should work to me...i don't think I changed the exports at all 👍

nhunzaker added a commit to nhunzaker/react that referenced this pull request Jun 13, 2017

@flarnie flarnie referenced this pull request Jun 13, 2017

Closed

React 15.6 Umbrella #9398

41 of 49 tasks complete

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v16 #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment