Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RocksDB not work with network filesystem paths on Windows (like \\hostname\folder\...) #8345

Closed
prigluchenie opened this issue May 28, 2021 · 4 comments
Closed

RocksDB not work with network filesystem paths on Windows (like \\hostname\folder\...) #8345

prigluchenie opened this issue May 28, 2021 · 4 comments
Labels
question up-for-grabs Up for grabs windows

Comments

@prigluchenie
Copy link

prigluchenie commented May 28, 2021 •
edited
Loading

Problem occurs near

rocksdb/file/filename.cc

Line 467 in 1c88f66

if (!dst.empty() && (c == kFilePathSeparator || c == '/') &&

during normalizing front double slash.

RocksDB worked with network filesystem paths in the version 6.6.4 (for example).
@hx235 hx235 added up-for-grabs Up for grabs question labels Dec 5, 2021
@igorrogov
Copy link

We have the same issue. The last version where it worked was 6.14.6, so we had to downgrade to this version because of that bug.

@riversand963
Copy link
Contributor

Thanks for reporting. Would you like to contribute a fix?

@igorrogov
Copy link

Yes, we might. One of our developers will be looking into it soon. I'll ask him to send a patch/PR.

bbkot added a commit to bbkot/rocksdb that referenced this issue Jan 14, 2022
@bbkot
fixing issue facebook#8345 RocksDB not work with network filesystem p…
5991ba8 
…aths on Windows
@bbkot bbkot mentioned this issue Jan 14, 2022
Closed
@bbkot
Copy link
Contributor

bbkot commented Jan 14, 2022

created pull request , with solution proposed solution
here you are the link

#9384

ajkr pushed a commit that referenced this issue Apr 18, 2022
@bbkot @ajkr
fixing issue #8345 RocksDB does not work when using UNC network paths (…
e07d836 
…#9384)

Summary:
Fix #8345
RocksDB does not work with network filesystem paths on Windows, e.g. "\\hostname\folder\..."

Pull Request resolved: #9384

Reviewed By: mrambacher

Differential Revision: D33830622

Pulled By: riversand963

fbshipit-source-id: 2a99dc3c94415eb1460e110784b97d71600218f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question up-for-grabs Up for grabs windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixing issue #8345 RocksDB does not work when using UNC network paths bbkot/rocksdb
6 participants
@igorrogov @riversand963 @ramvadiv @prigluchenie @hx235 @bbkot