Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compression.h(781,53): warning C4267: 'argument': conversion from 'size_t' to 'uLong', possible loss of data #9688

Closed
theolivenbaum opened this issue Mar 12, 2022 · 0 comments
Labels
Build build, makefile, cmake, scripts

Comments

@theolivenbaum
Copy link
Contributor

I'm trying to fix our build pipeline for Windows since the release 7.0.1, and hitting an issue with the warning C4267 treated as error.

It seems like the offending line was introduced by this commit: 926ee13

  // Get an upper bound on the compressed size.
  size_t upper_bound = deflateBound(&_stream, length);
  output->resize(output_header_len + upper_bound);

I'll disable the warning for now, but I assume this would better be fixed in the code.

@ajkr ajkr added up-for-grabs Up for grabs Build build, makefile, cmake, scripts labels Mar 12, 2022
@jay-zhuang jay-zhuang removed the up-for-grabs Up for grabs label Mar 15, 2022
ajkr pushed a commit that referenced this issue Mar 23, 2022
Summary:
```
conversion from 'size_t' to 'uLong', possible loss of data
```

Fix #9688

Pull Request resolved: #9699

Reviewed By: riversand963

Differential Revision: D34901116

Pulled By: jay-zhuang

fbshipit-source-id: 969148a7a8c023449bd85055a1f0eec71d0a9b3f
jay-zhuang added a commit that referenced this issue Mar 29, 2022
Summary:
```
conversion from 'size_t' to 'uLong', possible loss of data
```

Fix #9688

Pull Request resolved: #9699

Reviewed By: riversand963

Differential Revision: D34901116

Pulled By: jay-zhuang

fbshipit-source-id: 969148a7a8c023449bd85055a1f0eec71d0a9b3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build build, makefile, cmake, scripts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants