Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos in some code and comment #10139

Closed
wants to merge 3 commits into from
Closed

fix typos in some code and comment #10139

wants to merge 3 commits into from

Conversation

yzhao244
Copy link
Contributor

@yzhao244 yzhao244 commented Jun 9, 2022

Minor issue, I just found a few typos on db_test and column_family while reading the code. And I have this PR opened to contribute. :)

@facebook-github-bot
Copy link
Contributor

Hi @yzhao244!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@yzhao244
Copy link
Contributor Author

@siying @ajkr Hi guys, this is my first PR for rocksdb community. :) .. not too sure about the PR review process. Do I have to manually add one of you guys to be the reviewer of the PR?Or I just wait lol..

siying
siying reviewed Jun 16, 2022
View reviewed changes
Copy link
Contributor

@siying siying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

db/db_test.cc Show resolved Hide resolved
@yzhao244
Copy link
Contributor Author

@siying addressed the review comment, should be good this time.

@yzhao244
Copy link
Contributor Author

yzhao244 commented Jul 8, 2022

@siying any updates on merging :)

@yzhao244
Copy link
Contributor Author

@siying @ajkr any updates on when to merge. :)

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@yzhao244 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siying siying siying left review comments

@jay-zhuang jay-zhuang jay-zhuang approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yzhao244 @facebook-github-bot @jay-zhuang @siying