Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table_test.cc: fix ReverseKeyComparator::Name #10218

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −4
Open

table_test.cc: fix ReverseKeyComparator::Name #10218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c97e69
table_test.cc: ReverseKeyComparator name should not be "ReverseBytewi…
rockeet Jun 20, 2022
b88e8b7
run make format
rockeet Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions table/table_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,7 @@ std::string Reverse(const Slice& key) {

class ReverseKeyComparator : public Comparator {
public:
const char* Name() const override {
return "rocksdb.ReverseBytewiseComparator";
}
const char* Name() const override { return "rocksdb.ReverseKeyComparator"; }

int Compare(const Slice& a, const Slice& b) const override {
return BytewiseComparator()->Compare(Reverse(a), Reverse(b));
Expand Down Expand Up @@ -1827,7 +1825,7 @@ TEST_P(BlockBasedTableTest, BlockBasedTableProperties2) {

auto& props = *c.GetTableReader()->GetTableProperties();

ASSERT_EQ("rocksdb.ReverseBytewiseComparator", props.comparator_name);
ASSERT_EQ("rocksdb.ReverseKeyComparator", props.comparator_name);
ASSERT_EQ("UInt64AddOperator", props.merge_operator_name);
ASSERT_EQ("rocksdb.Noop", props.prefix_extractor_name);
ASSERT_EQ(
Expand Down