Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual compactions to run in parallel by default #10317

Closed
wants to merge 5 commits into from

Commits on Jul 6, 2022

  1. Allow manual compactions to run in parallel by default

    This PR changes the default value of
    `CompactRangeOptions::exclusive_manual_compaction` from true to false so
    manual `CompactRange()`s can run in parallel with other compactions. I
    believe no artificial parallelism restriction is the intuitive behavior
    so feel the old default value is a trap, which I have fallen into
    several times, including yesterday.
    `CompactRangeOptions::exclusive_manual_compaction == false` has been
    used in both our correctness test and in production for years so should
    be reasonably safe.
    ajkr committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    d38ebd8 View commit details
    Browse the repository at this point in the history
  2. fix test

    ajkr committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    b0d3873 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Configuration menu
    Copy the full SHA
    e509a2d View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Configuration menu
    Copy the full SHA
    b26b9f9 View commit details
    Browse the repository at this point in the history
  2. Update HISTORY.md

    ajkr authored Jul 28, 2022
    Configuration menu
    Copy the full SHA
    23884eb View commit details
    Browse the repository at this point in the history