Print perf context for all benchmarks if enabled #10396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: If user runs `db_bench` with `-perf_level=2` or higher, db_bench should print perf context after each of all benchmarks. Or make `-perf_level` a per-benchmark switch. Test Plan: ./db_bench -benchmarks=fillseq,readseq -perf_level=2
|
Not sure if this behavior is ok with you, cc @mdcallag |
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: In db_stress, we have '-progress_reports' that controls whether the process prints finished ops periodically to stdout. We can have the same knob for db_bench, which can be handy when redirecting the output of db_bench to files. Test Plan: ./db_bench -benchmarks=fillseq -progress_reprots=false ./db_bench -benchmarks=fillseq The first command disables progress reporting, while the second enables.
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks @ajkr for the review! |
Ugh, sorry for missing this. Thanks for the improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If user runs
db_benchwith-perf_level=2or higher, db_bench shouldprint perf context after each of all benchmarks.
Or make
-perf_levela per-benchmark switch.Test Plan:
./db_bench -benchmarks=fillseq,readseq -perf_level=2