Fix data race reported on SetIsInSecondaryCache in LRUCache #10472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gitbw95 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
added 2 commits
August 3, 2022 14:40
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
|
@gitbw95 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pdillinger
reviewed
Aug 3, 2022
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
|
@gitbw95 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently,
SetIsInSecondaryCacheis afterPromote. AfterPromote, a handle can be accessed and its flags can be set. This causes data race.Test Plan:
unit tests
stress tests