Reset blob value as soon as it's not needed in DBIter #10490
Conversation
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ltamasi
force-pushed
the
iter_reset_blob_value
branch
from
71762a1
to
16243e7
Compare
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ltamasi
force-pushed
the
iter_reset_blob_value
branch
from
16243e7
to
001cb86
Compare
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ltamasi
force-pushed
the
iter_reset_blob_value
branch
from
001cb86
to
14654f1
Compare
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
2 similar comments
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
We have recently added caching support to BlobDB, and separately,
implemented an optimization where reading blobs from the cache
results in the cache handle being transferred to the target
PinnableSlice(as opposed to the contents getting copied). With these changes,
it makes sense to reset the
PinnableSlicestoring the blob value inDBIteras soon as we move to a different iterator position to preventus from holding on to the cache handle any longer than necessary.
Test Plan:
make check