Introduce a dedicated class to represent blob values #10571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est.GetBlobsFromSecondaryCache
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
riversand963
approved these changes
Aug 25, 2022
|
|
||
| std::unique_ptr<BlobContents> BlobContents::Create( | ||
| CacheAllocationPtr&& allocation, size_t size) { | ||
| return std::unique_ptr<BlobContents>( |
There was a problem hiding this comment.
Can we use std::make_unique?
There was a problem hiding this comment.
Unfortunately, make_unique / make_shared don't work when the constructor is private, and making them a friend isn't an option either because the name of the actual low-level method that would call the constructor is implementation-defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The patch introduces a new class called
BlobContents, which representsa single uncompressed blob value. We currently use
std::stringfor thispurpose;
BlobContentsis somewhat smaller but the primary reason for adedicated class is that it enables certain improvements and optimizations
like eliding a copy when inserting a blob into the cache, using custom
allocators, or more control over and better accounting of the memory usage
of cached blobs (see #10484).
(We plan to implement these in subsequent PRs.)
Test Plan:
make check