Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support for async_io with tailing iterators #10781

Closed
wants to merge 2 commits into from
Closed

Provide support for async_io with tailing iterators #10781

wants to merge 2 commits into from

Conversation

akankshamahajan15
Copy link
Contributor

@akankshamahajan15 akankshamahajan15 commented Oct 6, 2022 •
edited
Loading

Summary: Provide support for async_io if ReadOptions.tailing is set true.

Test Plan:

  • Update unit tests
  • Ran db_bench: ./db_bench --benchmarks="readrandom" --use_existing_db --use_tailing_iterator=1 --async_io=1

@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@akankshamahajan15 akankshamahajan15 changed the title Provide support for async_io with ReadOption.tailing Provide support for async_io with tailing iterators Oct 6, 2022
@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

anand1976
anand1976 reviewed Oct 8, 2022
View reviewed changes
db/forward_iterator.cc Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

anand1976
anand1976 approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@anand1976 anand1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A couple of minor comments.

db/forward_iterator.cc Show resolved Hide resolved
db/forward_iterator.cc Show resolved Hide resolved
@akankshamahajan15
Provide support for async_io with ReadOption.tailing
b4e2832 
Summary: Provide support for async_io if ReadOptions.tailing is set
true.

Test Plan: Update unit test

Reviewers:

Subscribers:

Tasks:

Tags:
@akankshamahajan15
Addressed comments
3708801 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anand1976 anand1976 anand1976 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akankshamahajan15 @facebook-github-bot @anand1976