Rename block_cache_trace_analyzer_tool in CMakeLists #10814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jay-zhuang
approved these changes
Oct 13, 2022
|
@Qiaolin-Yu has updated the pull request. You must reimport the pull request before landing. |
|
@Qiaolin-Yu has updated the pull request. You must reimport the pull request before landing. |
|
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the name of
block_cache_trace_analyzer_toolinCMakeLists.txtis somewhat confusing.Makefile
The same thing in Makefile is called
block_cache_trace_analyzer.RocksDB Wiki
Also, in the Block-cache-analysis-and-simulation-tools of RocksDB Wiki, it is called
block_cache_trace_analyzertoo.Therefore, I think maybe it's better to rename
block_cache_trace_analyzer_tooltoblock_cache_trace_analyzerinCMakeLists.txt.