Fix a bug where GetContext does not update READ_NUM_MERGE_OPERANDS #10925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
riversand963
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The patch fixes a bug where
GetContext::Merge(andMergeEntity) does not update the tickerREAD_NUM_MERGE_OPERANDSbecause it implicitly uses the default parameter value ofupdate_num_ops_stats=falsewhen callingMergeHelper::TimedFullMerge. Also, to prevent such issues going forward, the PR removes the default parameter values from theTimedFullMergemethods. In addition, it removes an unused/unnecessary parameter fromTimedFullMergeWithEntity, and does some cleanup at the call sites of these methods.Test Plan:
make check