Support Merge with wide-column entities in iterator #10941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…medFullMergeWithEntity
…medFullMergeWithEntity
Summary: `DBIter::saved_value_` stores the result of any `Merge` that was performed to compute the iterator's current value. This value can be ditched whenever the iterator's position is changed, and is already cleared in `Seek`, `SeekForPrev`, `SeekToFirst`, and `SeekToLast`. With the patch, it is also cleared in `Next` and `Prev`. Test Plan: `make check`
|
@ltamasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks a lot for the quick review @riversand963 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The patch adds
Mergesupport for wide-column entities inDBIter. As before, theMergeoperation is applied to the default column of the entity; any other columns are unchanged. As a small cleanup, the PR also changes the signature ofDBIter::Mergeto simply return a boolean instead of theMergeoperation'sStatussince the actualStatusis already stored in a member variable.Test Plan:
make check