Support tiering when file endpoints overlap #10961
Conversation
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ajkr
force-pushed
the
support-tiering-with-delrange
branch
from
88d05cd
to
3bf7ce8
Compare
|
@ajkr has updated the pull request. You must reimport the pull request before landing. |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ajkr has updated the pull request. You must reimport the pull request before landing. |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| } | ||
| auto* snap2 = db_->GetSnapshot(); | ||
| assert(kNumKeysPerFile >= 5); |
There was a problem hiding this comment.
Oh it was to ensure the below range tombstones are non-overlapping and there is one spanning the middle L5 file's left endpoint, one fully contained within the L5 file, and one spanning the middle L5 file's right endpoint. In retrospect I think the only part that matters is overlapping the endpoints, which doesn't need this assert, so I'll remove it.
| DestroyAndReopen(options); | ||
|
|
||
| // pass some time first, otherwise the first a few keys write time are going | ||
| // to be zero, and internally zero has special meaning: kUnknownSeqnoTime | ||
| dbfull()->TEST_WaitForPeridicTaskRun( | ||
| [&] { mock_clock_->MockSleepForSeconds(static_cast<int>(10)); }); | ||
| [&] { mock_clock_->MockSleepForSeconds(static_cast<int>(kKeyPerSec)); }); |
ajkr
force-pushed
the
support-tiering-with-delrange
branch
from
926a1d7
to
d54df47
Compare
| } | ||
| auto* snap2 = db_->GetSnapshot(); | ||
| assert(kNumKeysPerFile >= 5); |
There was a problem hiding this comment.
Oh it was to ensure the below range tombstones are non-overlapping and there is one spanning the middle L5 file's left endpoint, one fully contained within the L5 file, and one spanning the middle L5 file's right endpoint. In retrospect I think the only part that matters is overlapping the endpoints, which doesn't need this assert, so I'll remove it.
| DestroyAndReopen(options); | ||
|
|
||
| // pass some time first, otherwise the first a few keys write time are going | ||
| // to be zero, and internally zero has special meaning: kUnknownSeqnoTime | ||
| dbfull()->TEST_WaitForPeridicTaskRun( | ||
| [&] { mock_clock_->MockSleepForSeconds(static_cast<int>(10)); }); | ||
| [&] { mock_clock_->MockSleepForSeconds(static_cast<int>(kKeyPerSec)); }); |
|
@ajkr has updated the pull request. You must reimport the pull request before landing. |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Enabled output to penultimate level when file endpoints overlap. This is probably only possible when range tombstones span files. Otherwise the overlapping files would all be included in the penultimate level inputs thanks to our atomic compaction unit logic.
Also, corrected
penultimate_output_range_type_, which is a minor fix as it appears only used for logging.Test Plan: updated unit test