Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snappy dependency for Java releases. #12207

Closed
wants to merge 3 commits into from
Closed

Update snappy dependency for Java releases. #12207

wants to merge 3 commits into from

Conversation

rhubner
Copy link
Contributor

@rhubner rhubner commented Jan 5, 2024 •
edited
Loading

No description provided.

@adamretter adamretter self-requested a review January 5, 2024 12:57
@rhubner rhubner force-pushed the eb/snappy-update branch 3 times, most recently from 3afbf1b to d22ba0c Compare February 8, 2024 05:54
@pdillinger
Copy link
Contributor

Super weird to see the warnings as error in Snappy because

cd snappy-1.1.10/build && CFLAGS='-arch x86_64  ' CXXFLAGS='-arch x86_64  ' LDFLAGS=' ' cmake -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DSNAPPY_BUILD_BENCHMARKS=OFF -DSNAPPY_BUILD_TESTS=OFF --compile-no-warning-as-error  .. && /Applications/Xcode_14.3.1.app/Contents/Developer/usr/bin/make 
                                                                                                                                                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@rhubner rhubner force-pushed the eb/snappy-update branch 2 times, most recently from 3821ac4 to 570e35c Compare June 20, 2024 08:30
@rhubner rhubner marked this pull request as ready for review July 2, 2024 14:44
@adamretter
Copy link
Collaborator

@pdillinger could we get this one merged please?

@facebook-github-bot
Copy link
Contributor

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cbi42 merged this pull request in b6c3495.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamretter adamretter adamretter approved these changes

@cbi42 cbi42 cbi42 approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rhubner @pdillinger @adamretter @facebook-github-bot @cbi42