FixOSX Build fallocate #1827
FixOSX Build fallocate #1827
Conversation
util/io_posix.h
Outdated
| @@ -114,9 +114,11 @@ class PosixWritableFile : public WritableFile { | |||
| #ifdef ROCKSDB_FALLOCATE_PRESENT | |||
| virtual Status Allocate(uint64_t offset, uint64_t len) override; | |||
| #endif | |||
| #ifdef OS_LINUX | |||
| virtual Status RangeSync(uint64_t offset, uint64_t nbytes) override; | |||
| virtual size_t GetUniqueId(char* id, size_t max_size) const override; | |||
| }; | |||
There was a problem hiding this comment.
you need the }; even if non-Linux
|
@siying updated the pull request - view changes |
|
Since the build is broken and it takes too long for this diff's turn of Travis. I'm committing it. |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
3 similar comments
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@siying updated the pull request - view changes - changes since last import |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Replaced by #1830 |
The recent update about fallocate failed OSX build. Fix it.