Dump compression dictionary meta-block #1837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
table/block_based_table_reader.cc
Outdated
|
|
||
| // Output compression dictionary | ||
| auto compression_dict = rep_->compression_dict_block->data; | ||
| if (!compression_dict.empty()) { |
There was a problem hiding this comment.
Should we check that compression_dict != nullptr
There was a problem hiding this comment.
need to check compression_dict_block, yes, thanks!
|
@ajkr updated the pull request - view changes |
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
VitaliyLi
pushed a commit
to VitaliyLi/rocksdb
that referenced
this pull request
Feb 3, 2017
Summary: make sst_dump print size/contents of the dictionary meta-block for easier debugging Closes facebook#1837 Differential Revision: D4506399 Pulled By: ajkr fbshipit-source-id: b9bf668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sst_dump print size/contents of the dictionary meta-block for easier debugging
Test Plan: ran
sst_dump --command=rawon a file compressed with dictionary, verified it looked as expected