Remove disableDataSync option #1859
Conversation
|
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
util/options_helper.h
Outdated
| OptionVerificationType::kNormal, false, 0}}, | ||
| {"disable_data_sync", // for compatibility | ||
| {offsetof(struct DBOptions, disableDataSync), OptionType::kBoolean, | ||
| OptionVerificationType::kNormal, false, 0}}, |
There was a problem hiding this comment.
Can you still leave the two as OptionVerificationType::kDeprecated?
|
@sagar0 updated the pull request - view changes - changes since last import |
|
Seems like I messed up my merge. Let me try again. |
sagar0
force-pushed
the
rm_disableDataSync
branch
from
0b0927d
to
226e8ff
Compare
|
@sagar0 updated the pull request - view changes - changes since last import |
|
@sagar0 updated the pull request - view changes - changes since last import |
|
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I think I fixed the bad merges now :) |
|
Awesome! Go to go! |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Can you remove uses of disableDataSync in fbcode? In the future consider just marking the option as deprecated, it can save some migration effort compared to breaking API changes :p. |
|
Oh, didn't know I had to change something in fbcode as well. Sure, I'll try fixing it on Monday. |
|
Thanks! |
Would you please link or comment here as to what other methods you're referring to? Also, FYI this option is still referenced from the basic operations and RocksDB-Tuning-Guide wiki pages. Thanks! |
|
@jgraettinger Thanks for pointing out the referenced pages; I removed disableDataSync references from them, and also made sure that the wiki does not contain any more references (using google site search).
Having more flush and compaction threads is the way to go instead of continuing to use disableDataSync option. |
Remove disableDataSync, and another similarly named disable_data_sync options.
This is being done to simplify options, and also because the performance gains of this feature can be achieved by other methods.