Add stderr log level for ldb backup commands #1939
Conversation
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
tools/ldb_cmd.cc
Outdated
| backup_options.max_background_operations = thread_num_; | ||
| BackupableDBOptions(backup_dir_, custom_env); | ||
| if (stderr_log_level_ != InfoLogLevel::NUM_INFO_LOG_LEVELS) { | ||
| backup_options.info_log = new StderrLogger(stderr_log_level_); |
There was a problem hiding this comment.
yes, thanks!
BTW, does anyone know what's wrong with the sandcastle logs? I see "output truncated" in the logs and no obvious failure messages, despite being red.
ajkr
changed the title
|
@ajkr updated the pull request - view changes - changes since last import |
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ajkr updated the pull request - view changes - changes since last import |
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ajkr updated the pull request - view changes - changes since last import |
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Also extracted the common logic into a base class, BackupableCommand.
Test Plan: run a bunch of ldb backup/restore commands, like
./ldb restore --db=./tmp-rst --backup_dir=./tmp-bk --stderr_log_level=1./ldb backup --db=./tmp --backup_dir=./tmp-bk --stderr_log_level=1