Allow Users to change customized ldb tools' header in help printing #2018
Conversation
|
@IslamAbdelRahman @ajkr MyRocks is asking us to change the banner of the ldb tool. I'm going to allow users to plug in their own string and rename the name from LevelDB to RocksDB in default ldb. |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
include/rocksdb/ldb_tool.h
Outdated
| @@ -26,6 +26,8 @@ struct LDBOptions { | |||
| // Key formatter that converts a slice to a readable string. | |||
| // Default: Slice::ToString() | |||
| std::shared_ptr<SliceFormatter> key_formatter; | |||
|
|
|||
| std::string print_help_header; | |||
There was a problem hiding this comment.
maybe we can just have a default message
std::string print_help_header = "A User-Customized RocksDB Tool";
and get rid of the if/else
|
@siying updated the pull request - view changes - changes since last import |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
i can't think of why anyone would need configurable help header |
|
@ajkr talking to you offline for this question. |
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
No description provided.