Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jni library name for PowerPC Architecture #2040

Closed
wants to merge 1 commit into from

Conversation

ayappanec
Copy link
Contributor

Right now, building rocksdbjava in PowerPC is broken due to JNI library name. I figured it out that "uname -m" and java's os.arch matches in PowerPC architecture. I made use of this advantage to fix the issue. More info can found from this issue --> #1317

@ayappanec
Copy link
Contributor Author

I also set it up a CI for rocksdb on PowerPC.

http://140.211.168.68:8080/job/Rocksdb/

@ayappanec
Copy link
Contributor Author

The Travis CI failure is not related to this PR.

@facebook-github-bot
Copy link
Contributor

@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@adamretter
Copy link
Collaborator

Looks good to me

@facebook-github-bot
Copy link
Contributor

@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ayappanec ayappanec deleted the rocksdb-ppc branch April 7, 2017 07:22
@bharatviswa504
Copy link

@adamretter rocksdb jar from next release will it have ppc so?

@ayappanec
Copy link
Contributor Author

@bharatviswa504 Good point. We are also waiting for the new release to have ppc library in rocksdb jar.
@adamretter If you have any issues with regarding to Power hardware, i can help you.

@adamretter
Copy link
Collaborator

@bharatviswa504 I do not have access to a PPC system on which I could build the binaries. @bharatviswa504 Is that something you could help with?

@ayappanec
Copy link
Contributor Author

@adamretter I have this jenkins CI running in Ubuntu 16.04.1 ppc64le for rocksdb http://140.211.168.68:8080/job/Rocksdb/.

If you need machine credentials to do your own build, i can share with you.

@adamretter
Copy link
Collaborator

@ayappanec That would be perfect. Can you email me the details - adam DoT retter AT googlemail .com

@ayappanec
Copy link
Contributor Author

@adamretter Just mailed you the details

@adamretter adamretter added the ppc label Apr 20, 2017
@bharatviswa504
Copy link

@ayappanec Thanks for providing machine.
@adamretter So from next build we will have ppc64le support in rocksdb jar, awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants