set min file count on L0->base compactions #2140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
siying
approved these changes
Apr 11, 2017
siying
reviewed
Apr 18, 2017
| @@ -1310,7 +1310,8 @@ void VersionStorageInfo::ComputeCompactionScore( | |||
| } else { | |||
| score = static_cast<double>(num_sorted_runs) / | |||
| mutable_cf_options.level0_file_num_compaction_trigger; | |||
| if (compaction_style_ == kCompactionStyleLevel && num_levels() > 1) { | |||
| if (score >= 1.0 && compaction_style_ == kCompactionStyleLevel && | |||
| num_levels() > 1) { | |||
There was a problem hiding this comment.
In line 1320, can we use mutable_cf_options.max_bytes_for_level_base instead of MaxBytesForLevel(base_level())?
There was a problem hiding this comment.
Yes, that seems like a good idea so we don't have to change base-level sizing in the current release! Will do it in the morning.
|
replaced with #2172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the L0 scoring change in #2027, individual L0 files may trigger compaction when dynamic level sizing is enabled. This behavior increases write-amp.
This diff is a temporary fix to prevent such single-file compactions until #2123 gets reviewed. We need one of these fixes for the next release.
Test Plan:
command: