add prefetch to PosixRandomAccessFile in buffered io #2196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lightmark has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@lightmark updated the pull request - view changes - changes since last import |
|
OSX is still not fixed. |
|
@lightmark updated the pull request - view changes - changes since last import |
lightmark
force-pushed
the
prefetch_user_read
branch
from
41c1633
to
d6c14c6
Compare
|
@lightmark updated the pull request - view changes - changes since last import |
|
@lightmark has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@lightmark updated the pull request - view changes - changes since last import |
|
@lightmark has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
yiwu-arbug
pushed a commit
that referenced
this pull request
Apr 28, 2017
Summary: Every time after a compaction/flush finish, we issue user reads to put the table into block cache which includes a couple of IO that read footer, index blocks, meta block, etc. So we implement Prefetch here to reduce IO. Closes #2196 Differential Revision: D4931782 Pulled By: lightmark fbshipit-source-id: 5a13d58dcab209964352322217193bbf7ff78149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time after a compaction/flush finish, we issue user reads to put the table into block cache which includes a couple of IO that read footer, index blocks, meta block, etc. So we implement Prefetch here to reduce IO.