Dump Blob DB options to info log #2671
Conversation
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@yiwu-arbug updated the pull request - view changes - changes since last import |
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@yiwu-arbug updated the pull request - view changes - changes since last import |
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
utilities/blob_db/blob_db.cc
Outdated
| @@ -100,8 +106,16 @@ Status BlobDB::Open(const DBOptions& db_options, | |||
| std::vector<ColumnFamilyHandle*>* handles, BlobDB** blob_db, | |||
| bool no_base_db) { | |||
| *blob_db = nullptr; | |||
| Status s; | |||
|
|
|||
| DBOptions my_db_options(db_options); | |||
There was a problem hiding this comment.
Lets rename my_db_options to something better, may be in a different PR.
|
@yiwu-arbug updated the pull request - view changes - changes since last import |
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: * Dump blob db options to info log * Remove BlobDBOptionsImpl to disallow dynamic cast *BlobDBOptions into *BlobDBOptionsImpl. Move options there to be constants or into BlobDBOptions. The dynamic cast is broken after #2645 * Change some of the default options * Remove blob_db_options.min_blob_size, which is unimplemented. Will implement it soon. Closes #2671 Differential Revision: D5529912 Pulled By: yiwu-arbug fbshipit-source-id: dcd58ca981db5bcc7f123b65a0d6f6ae0dc703c7
Summary:
Test Plan:
Run
./db_bench --use_blob_dband check the log.Sample: https://gist.github.com/yiwu-arbug/8b30b19de177713c8db9c4a99b63f27d