Support pragma once in all header files and cleanup some warnings #4339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ajkr
approved these changes
Sep 5, 2018
db/version_set.cc
Outdated
| file->largest.user_key().ToString(), | ||
| file->stats.num_reads_sampled.load(std::memory_order_relaxed), | ||
| file->being_compacted); | ||
| file->being_compacted }); |
port/dirent.h
Outdated
| #endif // OS_WIN | ||
|
|
||
| #endif // STORAGE_LEVELDB_PORT_DIRENT_H_ | ||
| #endif // OS_WIN |
There was a problem hiding this comment.
minor: the newline before EOF is missing
third-party/fbson/FbsonUtil.h
Outdated
| } // namespace fbson | ||
|
|
||
| #endif // FBSON_FBSONUTIL_H | ||
| } // namespace fbson |
util/crc32c_ppc.h
Outdated
| #endif | ||
|
|
||
| #endif | ||
| #endif |
util/file_reader_writer.cc
Outdated
| @@ -694,11 +694,11 @@ Status FilePrefetchBuffer::Prefetch(RandomAccessFileReader* reader, | |||
| buffer_.Alignment(alignment); | |||
| buffer_.AllocateNewBuffer(static_cast<size_t>(roundup_len), | |||
| copy_data_to_new_buffer, chunk_offset_in_buffer, | |||
| chunk_len); | |||
| static_cast<size_t>(chunk_len)); | |||
util/transaction_test_util.cc
Outdated
| @@ -258,7 +259,7 @@ Status RandomTransactionInserter::Verify(DB* db, uint16_t num_sets, | |||
| std::vector<uint16_t> set_vec(num_sets); | |||
| std::iota(set_vec.begin(), set_vec.end(), static_cast<uint16_t>(0)); | |||
| if (rand) { | |||
| std::random_shuffle(set_vec.begin(), set_vec.end(), | |||
| std::random_shuffle(set_vec.begin(), set_vec.end(), | |||
utilities/blob_db/blob_db_impl.cc
Outdated
| @@ -1041,7 +1041,7 @@ Status BlobDBImpl::GetBlobValue(const Slice& key, const Slice& index_entry, | |||
| } | |||
| Slice crc_slice(blob_record.data(), sizeof(uint32_t)); | |||
| Slice blob_value(blob_record.data() + sizeof(uint32_t) + key.size(), | |||
| blob_index.size()); | |||
| static_cast<size_t>(blob_index.size())); | |||
cngzhnp
force-pushed
the
pragma_once_and_cleanup_warnings
branch
from
0547a33
to
70f4c1f
Compare
|
@cngzhnp has updated the pull request. Re-import the pull request |
|
I tried to fix the minor issues, hope that everythıng seems OK now. |
There was a problem hiding this comment.
ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
rcane
pushed a commit
to rcane/rocksdb
that referenced
this pull request
Sep 13, 2018
…cebook#4339) Summary: As you know, almost all compilers support "pragma once" keyword instead of using include guards. To be keep consistency between header files, all header files are edited. Besides this, try to fix some warnings about loss of data. Pull Request resolved: facebook#4339 Differential Revision: D9654990 Pulled By: ajkr fbshipit-source-id: c2cf3d2d03a599847684bed81378c401920ca848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you know, almost all compilers support "pragma once" keyword instead of using include guards. To be keep consistency between header files, all header files are edited.
Besides this, try to fix some warnings about loss of data.