Add block cache tracer. #5410
Add block cache tracer. #5410
Conversation
There was a problem hiding this comment.
@HaoyuHuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@HaoyuHuang has updated the pull request. Re-import the pull request |
|
@HaoyuHuang has updated the pull request. Re-import the pull request |
|
@HaoyuHuang has updated the pull request. Re-import the pull request |
|
@HaoyuHuang has updated the pull request. Re-import the pull request |
|
@HaoyuHuang has updated the pull request. Re-import the pull request |
|
I updated src.mk. I also added the code to perform the downsampling. |
|
@HaoyuHuang has updated the pull request. Re-import the pull request |
|
Thanks for your comments. |
There was a problem hiding this comment.
LGTM with a few minor, last comments.
Thanks @HaoyuHuang for the PR.
src.mk
Outdated
| @@ -371,6 +372,7 @@ MAIN_SOURCES = \ | |||
| tools/reduce_levels_test.cc \ | |||
| tools/sst_dump_test.cc \ | |||
| tools/trace_analyzer_test.cc \ | |||
| trace_replay/block_cache_tracer_test.cc \ | |||
There was a problem hiding this comment.
You may also want to adjust the alignment of \. It's not strictly required, but other lines are trying to align.
There was a problem hiding this comment.
My bad. I changed my editor to show indentation now. I updated it.
trace_replay/block_cache_tracer.h
Outdated
| Status WriteHeader(); | ||
|
|
||
| private: | ||
| bool ShouldTrace(const BlockCacheTraceRecord& record); |
There was a problem hiding this comment.
bool ShouldTrace(const BlockCacheTraceRecord& record) const;?
|
@HaoyuHuang has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@HaoyuHuang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@HaoyuHuang merged this pull request in aa71718. |
Summary: This PR adds a help class block cache tracer to read/write block cache accesses. It uses the trace reader/writer to perform this task. Pull Request resolved: facebook#5410 Differential Revision: D15612843 Pulled By: HaoyuHuang fbshipit-source-id: f30fd1e1524355ca87db5d533a5c086728b141ea
Summary: This PR adds a help class block cache tracer to read/write block cache accesses. It uses the trace reader/writer to perform this task. Pull Request resolved: facebook/rocksdb#5410 Differential Revision: D15612843 Pulled By: HaoyuHuang fbshipit-source-id: f30fd1e1524355ca87db5d533a5c086728b141ea Signed-off-by: Changlong Chen <levisonchen@live.cn>
Summary: This PR adds a help class block cache tracer to read/write block cache accesses. It uses the trace reader/writer to perform this task. Pull Request resolved: facebook/rocksdb#5410 Differential Revision: D15612843 Pulled By: HaoyuHuang fbshipit-source-id: f30fd1e1524355ca87db5d533a5c086728b141ea Signed-off-by: Changlong Chen <levisonchen@live.cn>
This PR adds a help class block cache tracer to read/write block cache accesses. It uses the trace reader/writer to perform this task.