Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow concurrent CF iteration and drop #6005

Closed
wants to merge 4 commits into from
Closed

Allow concurrent CF iteration and drop #6005

wants to merge 4 commits into from

Commits on Nov 3, 2019

  1. Allow iterators to be released after CF close 

    Closing ColumnFamilyHandle with unreleased iterators is easy to cause coredump,
because the iterator release is controlled by java GC when using JNI.

This patch fixed it, we let an iterator hold a ColumnFamilyData reference to
prevent the CF from being released too early.

fixed facebook#5982
    @javeme
    javeme committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    85fe377 View commit details
    Browse the repository at this point in the history

  2. fix default cf release

    @javeme
    javeme committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    e57bb07 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. add test for cf release

    @javeme
    javeme committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    4562b51 View commit details
    Browse the repository at this point in the history

  2. fix RocksIterator release by GC after ColumnFamilyHandle

    @javeme
    javeme committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    e9a32ff View commit details
    Browse the repository at this point in the history