Break db_stress_tool.cc to a list of source files #6134
Conversation
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
siying
force-pushed
the
stress_refactor15
branch
from
cb24815
to
6394c34
Compare
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| @@ -402,9 +402,17 @@ cpp_library( | |||
| cpp_library( | |||
| name = "rocksdb_stress_lib", | |||
| srcs = [ | |||
| "db_stress_tool/batched_ops_stress.cc", | |||
There was a problem hiding this comment.
This file should not be edited manually. Instead, we run buckifier script to auto-gen this file.
There was a problem hiding this comment.
Actually, the file is auto generated by buckifer script.
| class BatchedOpsStressTest : public StressTest { | ||
| public: | ||
| BatchedOpsStressTest() {} | ||
| virtual ~BatchedOpsStressTest() {} |
There was a problem hiding this comment.
Since this is a refactoring, let's use 'override' instead of 'virtual' to make internal linter happy in all places that apply.
There was a problem hiding this comment.
Sure. I'll do it as a follow-up.
tools/stress_test_base.h
Outdated
| @@ -0,0 +1,7 @@ | |||
| // Copyright (c) 2011-present, Facebook, Inc. All rights reserved. | |||
There was a problem hiding this comment.
Is this file being used?
There was a problem hiding this comment.
Hmm. It's not. Let me remove it.
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: db_stress_tool.cc now is a giant file. In order to main it easier to improve and maintain, break it down to multiple source files. Most classes are turned into their own files. Separate .h and .cc files are created for gflag definiations. Another .h and .cc files are created for some common functions. Some test execution logic that is only loosely related to class StressTest is moved to db_stress_driver.h and db_stress_driver.cc. All the files are located under db_stress_tool/. The directory name is created as such because if we end it with either stress or test, .gitignore will ignore any file under it and makes it prone to issues in developements. Test Plan: Build under GCC7 with and without LITE on using GNU Make. Build with GCC 4.8. Build with cmake with -DWITH_TOOL=1
siying
force-pushed
the
stress_refactor15
branch
from
f7160cb
to
06d85f1
Compare
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
siying
force-pushed
the
stress_refactor15
branch
from
06d85f1
to
27f0419
Compare
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request has been merged in 7d79b32. |
Summary: db_stress_tool.cc now is a giant file. In order to main it easier to improve and maintain, break it down to multiple source files. Most classes are turned into their own files. Separate .h and .cc files are created for gflag definiations. Another .h and .cc files are created for some common functions. Some test execution logic that is only loosely related to class StressTest is moved to db_stress_driver.h and db_stress_driver.cc. All the files are located under db_stress_tool/. The directory name is created as such because if we end it with either stress or test, .gitignore will ignore any file under it and makes it prone to issues in developements. Pull Request resolved: facebook#6134 Test Plan: Build under GCC7 with and without LITE on using GNU Make. Build with GCC 4.8. Build with cmake with -DWITH_TOOL=1 Differential Revision: D18876064 fbshipit-source-id: b25d0a7451840f31ac0f5ebb0068785f783fdf7d
Summary:
db_stress_tool.cc now is a giant file. In order to main it easier to improve and maintain, break it down to multiple source files.
Most classes are turned into their own files. Separate .h and .cc files are created for gflag definiations. Another .h and .cc files are created for some common functions. Some test execution logic that is only loosely related to class StressTest is moved to db_stress_driver.h and db_stress_driver.cc. All the files are located under db_stress_tool/. The directory name is created as such because if we end it with either stress or test, .gitignore will ignore any file under it and makes it prone to issues in developements.
Test Plan:
Build under GCC7 with and without LITE on using GNU Make. Build with GCC 4.8. Build with cmake with -DWITH_TOOL=1