Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up VersionEdit a bit #6383

Closed
wants to merge 2 commits into from

Commits on Feb 6, 2020

  1. Clean up VersionEdit a bit

    Summary:
    This is a bunch of small improvements to VersionEdit. Namely, the patch
    
    * Makes the names and order of variables, methods, and code chunks related
      to the various information elements more consistent, and adds missing
      getters for the sake of completeness.
    * Initializes previously uninitialized stack variables.
    * Marks all getters const to improve const correctness.
    * Adds in-class initializers and removes the default ctor that would
      create an object with uninitialized built-in fields and call `Clear`
      afterwards.
    * Adds a new type alias for new files and changes the existing `typedef`
      for deleted files into a type alias as well.
    * Makes the helper method `DecodeNewFile4From` private.
    * Switches from long-winded iterator syntax to range based loops in a
      couple of places.
    * Fixes a couple of assignments where an integer 0 was assigned to
      boolean members.
    
    Test Plan:
    make check
    ltamasi committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    3e228c7 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Configuration menu
    Copy the full SHA
    893d8e0 View commit details
    Browse the repository at this point in the history