Add a simple timer support to schedule work at fixed times/intervals #6543
Conversation
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@sagar0 has updated the pull request. Re-import the pull request |
|
@sagar0 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@sagar0 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Somehow travis builds are no longer getting queued for this PR; not sure why. |
I think just the link failed to be provided. https://travis-ci.org/github/facebook/rocksdb/builds/667842142 |
|
@sagar0 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@sagar0 has updated the pull request. Re-import the pull request |
Added: Cancel CancelAll Changed from fns being on stack to heap, with unique_ptrs.
And fix a few lint warnings.
|
Rebased to fix conflicts. |
|
@sagar0 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@sagar0 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
All builds and tests passed. I don't know why AppVeyor is reporting a build failure when I see that all tests passed. |
|
@sagar0 can you retry again, or press "Ship It" in https://our.internmc.facebook.com/intern/diff/D20465390/ ? We have a new workflow now which requires accepting internally too. Now I accepted there and hope it works now. |
Adding a simple timer support to schedule work at a fixed time.
Test Plan:
Added new unit tests.