Update googletest from 1.8.1 to 1.10.0 #6808
Conversation
|
Because you want some new features? (just curious) |
|
@pdillinger I am working on some tests for improving the WriteBatch and WriteBatchWithIndex, I wanted to write some parameterized tests. I was getting compilation errors for the parameterized test syntax with 1.8.1, updating to 1.10.0 fixed this. |
adamretter
force-pushed
the
update-googletest
branch
from
defd795
to
5c47fef
Compare
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
CircleCI failure is just #6232 |
|
Actually, this is not so easy because our Facebook buck build uses a gtest 1.8.x version not in the RocksDB repository. What do you think? |
|
@pdillinger Unfortunately I don't have access to any internal FB systems. I tried to understand how the Buck build might work, but the public instructions for Buck seem to vary from how the RocksDB project is set-out. On a chance I ran
Without access to internal systems I am not sure I can help with the Buck stuff, unless you can point me at some docs or something? |
|
@pdillinger Any updates please? |
Summary: ... so that we have freedom to upgrade it (see facebook#6808). As a side benefit, gtest will no longer be linked into main library in buck build. Test Plan: fb internal build & link
Summary: ... so that we have freedom to upgrade it (see #6808). As a side benefit, gtest will no longer be linked into main library in buck build. Pull Request resolved: #6858 Test Plan: fb internal build & link Reviewed By: riversand963 Differential Revision: D21652061 Pulled By: pdillinger fbshipit-source-id: 6018104af944debde576b5beda6c134e737acedb
adamretter
force-pushed
the
update-googletest
branch
from
5c47fef
to
85ccef1
Compare
|
@adamretter has updated the pull request. Re-import the pull request |
|
@pdillinger Thanks, I have now updated this to incorporate your PR #6858 |
|
I can't add commits. Please run to fix formatting (other than gtest) |
|
@pdillinger Thanks. I have done that now. |
|
@adamretter has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
TARGETS says 1.10.1 instead of 1.10.0. Need to re-run |
adamretter
force-pushed
the
update-googletest
branch
from
005569d
to
5aaf8a6
Compare
|
@adamretter has updated the pull request. Re-import the pull request |
|
@pdillinger Doh! Okay I just fixed that TARGETS one and force-pushed |
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pdillinger merged this pull request in 8d87e9c. |
This reverts commit 8d87e9c. Based on offline discussions, it's too early to upgrade to gtest 1.10, as it prevents some developers from using an older version of gtest to integrate to some other systems. Revert it for now.
Summary: This reverts commit 8d87e9c. Based on offline discussions, it's too early to upgrade to gtest 1.10, as it prevents some developers from using an older version of gtest to integrate to some other systems. Revert it for now. Pull Request resolved: #6923 Reviewed By: pdillinger Differential Revision: D21864799 fbshipit-source-id: d0726b1ff649fc911b9378f1763316200bd363fc
No description provided.