Implement Java API for ConcurrentTaskLimiter class and compaction_thread_limiter field in ColumnFamilyOptions #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alucarded
changed the title
alucarded
changed the title
clang-format version 9.0.0-2~ubuntu18.04.2 (tags/RELEASE_900/final)
adamretter
approved these changes
Sep 7, 2020
|
@pdillinger Can you do the merge honours please? |
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jay-zhuang
reviewed
Sep 9, 2020
| auto* ptr = reinterpret_cast< | ||
| std::shared_ptr<ROCKSDB_NAMESPACE::ConcurrentTaskLimiter>*>(jhandle); | ||
| delete ptr; // delete std::shared_ptr | ||
| } |
There was a problem hiding this comment.
For future reference, yes. Please configure editors for newlines at end of file. (In this case it's easier for me to fix it within FB.)
|
@pdillinger merged this pull request in ec5add3. |
codingrhythm
pushed a commit
to SafetyCulture/rocksdb
that referenced
this pull request
Mar 5, 2021
…ead_limiter field in ColumnFamilyOptions (facebook#7347) Summary: as title Pull Request resolved: facebook#7347 Test Plan: unit tests included Reviewed By: jay-zhuang Differential Revision: D23592552 Pulled By: pdillinger fbshipit-source-id: 1c3571b6f42bfd0cfd723ff49d01fbc02a1be45b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: as title
Test Plan: unit tests included