Make db_basic_test pass assert status checked #7452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add db_basic_test status check list. Some of the warnings are suppressed. It is possible that some of them are due to real bugs. Test Plan: See CI tests pass.
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zhichao-cao
reviewed
Sep 29, 2020
db/db_impl/db_impl_write.cc
Outdated
| @@ -455,6 +456,7 @@ Status DBImpl::WriteImpl(const WriteOptions& write_options, | |||
| if (status.ok()) { | |||
| status = w.FinalStatus(); | |||
| } | |||
| // io_s.PermitUncheckedError(); | |||
There was a problem hiding this comment.
Should we remove it now?
zhichao-cao
reviewed
Sep 29, 2020
| @@ -246,16 +246,24 @@ Status DBImpl::FlushMemTableToOutputFile( | |||
| // be pessimistic and try write to a new MANIFEST. | |||
| // TODO: distinguish between MANIFEST write and CURRENT renaming | |||
There was a problem hiding this comment.
If it is convenient, you can also add .PermitUncheckedError() to the remaining SetBGError at about L1193 and about L3000
|
@siying has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
siying
added a commit
to siying/rocksdb
that referenced
this pull request
Sep 29, 2020
Summary: facebook#7452 added an uncessary skip for status code checking. Revert it. Test Plan: Watch CI to finish
|
This pull request has been merged in d08a900. |
codingrhythm
pushed a commit
to SafetyCulture/rocksdb
that referenced
this pull request
Mar 5, 2021
Summary: Add db_basic_test status check list. Some of the warnings are suppressed. It is possible that some of them are due to real bugs. Pull Request resolved: facebook#7452 Test Plan: See CI tests pass. Reviewed By: zhichao-cao Differential Revision: D23979764 fbshipit-source-id: 6151570c2a9b931b0fbb3fe939a94b2bd1583cbe
codingrhythm
pushed a commit
to SafetyCulture/rocksdb
that referenced
this pull request
Mar 5, 2021
Summary: facebook#7452 added an uncessary skip for status code checking. Revert it. Pull Request resolved: facebook#7458 Test Plan: Watch CI to finish Reviewed By: jay-zhuang Differential Revision: D23994390 fbshipit-source-id: a2b50a6326d8073db3386bff3d32acc5a6666e9b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add db_basic_test status check list. Some of the warnings are suppressed. It is possible that some of them are due to real bugs.
Test Plan: See CI tests pass.